Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified converter maps #147

Merged
merged 13 commits into from
Oct 5, 2023
Merged

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Oct 4, 2023

BEGINRELEASENOTES

  • Introduce a global object map that is shared by all converter instances (in either direction). This is necessary to properly set all relations even if the related objects are not converted in the same converter instance.
  • Add a global_converter_maps test case (and a description) that checks that this works as expected.

ENDRELEASENOTES

New iteration of #144 (see more discussion there)

This should solve #113 in the end.

@tmadlener tmadlener force-pushed the unified-converter-maps branch from 319fa8e to 0c1d89c Compare October 5, 2023 09:51
@tmadlener tmadlener force-pushed the unified-converter-maps branch from 0c1d89c to 2ef3afa Compare October 5, 2023 10:03
@tmadlener tmadlener merged commit d29e309 into key4hep:main Oct 5, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant