Make it possible to share maps between both directions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
unified-maps
branch
3 times, most recently
from
628e773 to
0049108
Compare
tmadlener
force-pushed
the
unified-maps
branch
2 times, most recently
from
7be3f9d to
8b7cbd9
Compare
tmadlener
force-pushed
the
unified-maps
branch
2 times, most recently
from
e721e6f to
ec93a42
Compare
tmadlener
commented
Sep 13, 2023
tmadlener
force-pushed
the
unified-maps
branch
from
e44e616 to
c77ea50
Compare
|
@andresailer @jmcarcell This is in principle ready for review. The diff looks huge, but most of that is d5ae846 and e916827 that shuffle quite a bit of code around. I keep it as WIP for now until I have also implemented the corresponding changes on the k4MarlinWrapper side, but I don't expect many changes here any longer. |
Merged
6 tasks
tmadlener
force-pushed
the
unified-maps
branch
2 times, most recently
from
17f2ab2 to
10bde59
Compare
|
The changes in the names of the maps in 49dccf2 makes this a breaking change for k4MarlinWrapper I am not sure if it is worth to try and make this a slightly smoother transition, or whether we just bit the bullet. |
andresailer
reviewed
Sep 26, 2023
tmadlener
force-pushed
the
unified-maps
branch
2 times, most recently
from
0945324 to
d4b4d15
Compare
tmadlener
changed the title
6 tasks
Preparation for more general mappnig structure
- Add generic mapInsert method
- Make all functions that take a map templated on the map(s)
- Make sure type deduction works for vector backed maps and actual
maps
- Default template map parameter such that shared library is built
with that and can be easily linked against
It is now possible to simply swap out the TypeMapT alias to switch to a
vector backed map
- Make conversion functions templated on map - Default map to what was there before to make it usable as a shared library
Necessary to build hierarchies that might span several collections
tmadlener
force-pushed
the
unified-maps
branch
from
d4b4d15 to
ec2f31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
vector<tuple<K, V>>or a propermap<K, V>).ENDRELEASENOTES
map<K, V>,unordered_map<K, V>,vector<tuple<K, V>>, ...