Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the version checks for Podio before 1.0 #80

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Delete the version checks for Podio before 1.0 #80

merged 2 commits into from
Aug 10, 2024

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Delete the version checks for Podio before 1.0

ENDRELEASENOTES

@jmcarcell jmcarcell mentioned this pull request Jul 2, 2024
Merged
@tmadlener
Copy link
Contributor

We should also bump the requirements in the find_package call when we go forward with this

k4EDM4hep2LcioConv/CMakeLists.txt

Line 44 in f6343b2

find_package(podio REQUIRED)

@jmcarcell jmcarcell force-pushed the rm-podio-pre1.0-compat branch from a050d25 to 62c3e0c Compare July 29, 2024 16:48
@jmcarcell jmcarcell force-pushed the rm-podio-pre1.0-compat branch from 62c3e0c to 0ffc9cf Compare August 10, 2024 16:57
@jmcarcell jmcarcell enabled auto-merge (squash) August 10, 2024 16:58
@jmcarcell jmcarcell force-pushed the rm-podio-pre1.0-compat branch from 0ffc9cf to ac49684 Compare August 10, 2024 17:22
@jmcarcell jmcarcell merged commit 21e4f40 into main Aug 10, 2024
5 of 7 checks passed
@jmcarcell jmcarcell deleted the rm-podio-pre1.0-compat branch August 10, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener