Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility with podio versions before v1.0 #334

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Remove compatibility with podio versions before 1.0

ENDRELEASENOTES

Since we already bumped this in our CMake config (#327), we can also remove this from our code.

Fixes #306

@tmadlener tmadlener force-pushed the rm-podio-pre1.0-compat branch from 0e49873 to 4d6a93f Compare July 1, 2024 16:17
.gitignore Outdated
Comment on lines 238 to 239
/include/podio/podioVersion.h
/python/podio/__init__.py
Copy link
Member

@jmcarcell jmcarcell Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These come from https://github.com/key4hep/key4hep-dev-utils/blob/main/defaults/.gitignore#L238, I think copied and pasted from the .gitignore in podio. The up to date ones seem to be so they could be in the central one even though it's not used for podio.

/python/podio/__version__.py
/python/podio_version.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is the global .gitignore, right? Why are we having podio specific ignores there? These should not appear in any repository, and the podio .gitignore is not globally managed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok they should be removed now, the changes here can be kept or not, they will be overwritten at some point anyway

@jmcarcell
Copy link
Member

I opened other PRs with the same changes in other repositories:

I think it's fine to merge them but they can also wait. The only case when keeping this code is useful is when someone wants to build the current versions on top of older versions of EDM4hep and Podio but not so old they don't work.

@tmadlener tmadlener force-pushed the rm-podio-pre1.0-compat branch from 4d6a93f to 39f0975 Compare July 3, 2024 18:34
@tmadlener tmadlener merged commit bdfaf4c into key4hep:main Jul 4, 2024
8 of 11 checks passed
@tmadlener tmadlener deleted the rm-podio-pre1.0-compat branch July 4, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove compatibility with podio < 1.0
2 participants