Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the EDM4hep to LCIO conversion to make it more consistent with the other direction #54

Merged
merged 14 commits into from
Mar 12, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Feb 21, 2024

BEGINRELEASENOTES

  • Rename all convXYZ methods to convertXYZ and deprecate the former versions for the EDM4hep to LCIO direction to make it more consistent with the other direction.
  • Cleanly split the EDM4hep to LCIO conversion into two steps, doing data conversion only in the first step and relation resolving in a second step.
    • Introduce resolveXYZRelations functions for all types where it is necessary and remove preliminary relation resolving from data conversion functions
    • All convertXYZ functions now only take one map that is populated as they no longer have to do any relation resolving
  • Add roundtrip tests for ReconstructedParticle conversion
    • Fix issue that was lurking here in passing by cleanly splitting conversion process into two steps

ENDRELEASENOTES

This is mainly a preparatory step to make #51 a bit easier to do and to have a bit more consistency between the different conversion directions.

@tmadlener tmadlener force-pushed the refactor-edm4hep2lcio branch from 22dc7b5 to d07159e Compare March 12, 2024 14:30
@tmadlener tmadlener merged commit bbc776d into key4hep:main Mar 12, 2024
5 of 8 checks passed
@tmadlener tmadlener deleted the refactor-edm4hep2lcio branch March 12, 2024 14:54
@tmadlener tmadlener mentioned this pull request Aug 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant