-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the EDM4hep to LCIO conversion to make it more consistent with the other direction #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
refactor-edm4hep2lcio
branch
from
February 21, 2024 12:30
21e98b8
to
e84a849
Compare
1 task
tmadlener
force-pushed
the
refactor-edm4hep2lcio
branch
3 times, most recently
from
February 21, 2024 16:18
b68a188
to
22dc7b5
Compare
4 tasks
relation resolving yet
tmadlener
force-pushed
the
refactor-edm4hep2lcio
branch
from
March 12, 2024 14:30
22dc7b5
to
d07159e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
convXYZ
methods toconvertXYZ
and deprecate the former versions for the EDM4hep to LCIO direction to make it more consistent with the other direction.resolveXYZRelations
functions for all types where it is necessary and remove preliminary relation resolving from data conversion functionsconvertXYZ
functions now only take one map that is populated as they no longer have to do any relation resolvingENDRELEASENOTES
This is mainly a preparatory step to make #51 a bit easier to do and to have a bit more consistency between the different conversion directions.