Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt the converter for dealing with reversed ParticleID relations #51

Merged
merged 18 commits into from
May 1, 2024
Merged

Adapt the converter for dealing with reversed ParticleID relations #51

merged 18 commits into from
May 1, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Feb 8, 2024 •
edited by jmcarcell
Loading

@tmadlener tmadlener mentioned this pull request Feb 21, 2024
Merged
1 task
@tmadlener tmadlener force-pushed the particleid-reversal branch from 73d56fb to 2e2c6eb Compare March 12, 2024 14:57
@tmadlener tmadlener force-pushed the particleid-reversal branch 2 times, most recently from 3b946d3 to 6f84362 Compare April 15, 2024 08:09
@tmadlener tmadlener mentioned this pull request Apr 16, 2024
Merged
3 tasks
@tmadlener tmadlener changed the title [WIP] Adapt the converter for dealing with reversed ParticleID relations Adapt the converter for dealing with reversed ParticleID relations Apr 16, 2024
tmadlener
tmadlener commented Apr 16, 2024
View reviewed changes
k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h Outdated Show resolved Hide resolved
k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.h Outdated Show resolved Hide resolved
k4EDM4hep2LcioConv/src/k4EDM4hep2LcioConv.cpp Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/src/EDM4hep2LCIOUtilities.cc Outdated Show resolved Hide resolved
tmadlener added 16 commits April 30, 2024 15:18
@tmadlener
Remove the ParticleID relation from the Clusters
87d52e8
@tmadlener
Remove the particleIDUsed from the reco particle
5a6629c
@tmadlener
Remove the particleID and make things compile again
5bb2b8e
@tmadlener
Convert ParticleIDs into separate collections from LCIO
d748386
@tmadlener
Update standalone converter tests to compare correctly for new layout
bf5e16a
@tmadlener
Remove unnecessary map and unused parameters
79dea96
@tmadlener
Remove no longer valid comment
e91a8e4
@tmadlener
Make roundtrip tests check ParticleIDs in new format
cf3885e
@tmadlener
Convert ParticleIDs also from EDM4hep to LCIO
fbef5f0
@tmadlener
Make interface const correct
1deac5a
@tmadlener
Use the EDM4hep PIDHandler in conversion to set meta info
a4c9c1e
@tmadlener
Try to keep 1-to-1 mapping for algorithmType in roundtrips
8f108f4
@tmadlener
Convert PID meta information in standalone conversion
d911082
@tmadlener
Move particle id metadata handling into reusable functionality
d6f2360
@tmadlener
Update docstrings
f6231ee
@tmadlener
Remove unused code, includes, and cmake config
59fcb17
@tmadlener tmadlener force-pushed the particleid-reversal branch from 7a20670 to 59fcb17 Compare April 30, 2024 13:18
@tmadlener tmadlener mentioned this pull request Apr 30, 2024
Merged
1 task
@hegner hegner merged commit f870d19 into key4hep:main May 1, 2024
1 of 8 checks passed
@Zehvogel Zehvogel mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @hegner