Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change probability to ndf in Vertex #324

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Change probability to ndf in Vertex #324

merged 2 commits into from
Jun 28, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 19, 2024

As discussed in #318.

Looks like this is unused except in the converter.

BEGINRELEASENOTES

  • Change probability to ndf in Vertex

ENDRELEASENOTES

Changes in other repos:

@jmcarcell jmcarcell force-pushed the probability-to-ndf branch from b7b736a to ee16ce7 Compare June 19, 2024 20:05
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you prepare the corresponding change in the converter, or shall I do it?

@tmadlener tmadlener linked an issue Jun 20, 2024 that may be closed by this pull request
@jmcarcell
Copy link
Member Author

I can have a look

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will let you merge this once all the other pieces are in place for not breaking the nightlies.

@andresailer andresailer requested a review from kjvbrt June 25, 2024 07:09
kjvbrt pushed a commit to HEP-FCC/FCCAnalyses that referenced this pull request Jun 26, 2024
@tmadlener tmadlener force-pushed the probability-to-ndf branch from 8a6347d to 11749d3 Compare June 28, 2024 11:33
@tmadlener tmadlener merged commit ca9de56 into main Jun 28, 2024
14 of 17 checks passed
@tmadlener tmadlener deleted the probability-to-ndf branch June 28, 2024 11:43
jalimena pushed a commit to FCC-LLP/FCCAnalyses that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertex probability member should be ndf
2 participants