Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex probability member should be ndf #318

Closed
tmadlener opened this issue Jun 18, 2024 · 3 comments · Fixed by #324
Closed

Vertex probability member should be ndf #318

tmadlener opened this issue Jun 18, 2024 · 3 comments · Fixed by #324
Labels
discussion Discussion item

Comments

@tmadlener
Copy link
Contributor

The Vertex currently has members chi2 and probability. The much more natural choice in this case would be to have ndf instead of probability, since that gives the information about the fit quality on a lower level from which higher level quantities, such as probability can be easily calculated.

EDM4hep/edm4hep.yaml

Lines 551 to 557 in bd9f450

edm4hep::Vertex:
Description: "Vertex"
Author: "EDM4hep authors"
Members:
- int32_t primary // boolean flag, if vertex is the primary vertex of the event
- float chi2 // chi-squared of the vertex fit
- float probability // probability of the vertex fit

@tmadlener tmadlener added the discussion Discussion item label Jun 18, 2024
@jmcarcell
Copy link
Member

I think other than in the converter probability is never used in Key4hep and others and this change makes sense. Also going from chi2 and ndf to probability is trivial while the other way not so much. For tracks we already have ndf.

Thinking about all the fits there is also Hyptothesis that has chi2 but no probability nor ndf. In case these proliferate (if it's only for tracks and vertexes then maybe it's not worth it), we may want to introduce something like a FitResult that would have chi2 and ndf and provide some utilities to get the p value if there is a need for it.

@tmadlener
Copy link
Contributor Author

Yeah, for Hypothesis I am also not entirely sure what the chi2 is exactly. See also one point on this #323

I agree with the rest. I would be in favor of keeping chi2 and ndf for now (mainly because it is less work ;) )

@gaede
Copy link
Collaborator

gaede commented Jun 19, 2024

We (BH, JMC, FG) agree to replace probability w/ ndf - and suggest to not introduce a component now.

@tmadlener tmadlener linked a pull request Jun 20, 2024 that will close this issue
@tmadlener tmadlener moved this from Todo to Ready for review in EDM4hep v1.0 Jun 26, 2024
@github-project-automation github-project-automation bot moved this from Ready for review to Done in EDM4hep v1.0 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion item
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants