Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the edm4hep::ObjectID from the components #260

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Remove the edm4hep::ObjectID from the components #260

merged 4 commits into from
Feb 22, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Feb 1, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Remove the edm4hep::ObjectID component. Fixes Remove the edm4hep::ObjectID from the datamodel #259
  • Remove its usage from the edm4hep::TrackerHit and edm4hep::TrackerHitPlane
  • This is a breaking change both in code and existing files. Existing usages might switch to use the podio::ObjectID to have effectively the same functionality.

ENDRELEASENOTES

  • Breaks in CEPCSW
  • Fix README.md links once this becomes ready to be merged.

@tmadlener tmadlener mentioned this pull request Feb 1, 2024
Closed
@fucd fucd mentioned this pull request Feb 3, 2024
Merged
@tmadlener
Copy link
Contributor Author

The rawHits are used extensively in CEPCSW!

@jmcarcell jmcarcell mentioned this pull request Feb 22, 2024
Open
@jmcarcell
Copy link
Member

I think this is ready to go?

@jmcarcell jmcarcell enabled auto-merge (squash) February 22, 2024 13:50
@jmcarcell
Copy link
Member

I'll enable auto-merge. It will take a while though 💻 🔥

@tmadlener tmadlener disabled auto-merge February 22, 2024 13:54
@tmadlener
Copy link
Contributor Author

Wait, let me quickly check if this does indeed not break anything else than CEPCSW. Will re-enable automerge once that is confirmed.

@tmadlener tmadlener enabled auto-merge (squash) February 22, 2024 14:29
@tmadlener tmadlener merged commit d0deb7f into key4hep:main Feb 22, 2024
12 of 13 checks passed
@tmadlener tmadlener mentioned this pull request Mar 18, 2024
Closed
@tmadlener tmadlener deleted the rm-object-id branch March 18, 2024 14:34
@tmadlener tmadlener mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the edm4hep::ObjectID from the datamodel
2 participants
@tmadlener @jmcarcell