edm4hep version control for ObjectID #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @fucd. As the latest release of edm4hep is 0.10.4, we can use this. Otherwise the CI will fail. |
mirguest
approved these changes
Feb 22, 2024
tmadlener
reviewed
Feb 22, 2024
| @@ -17,9 +26,15 @@ class Navigation{ | |||
| void AddTrackerHitCollection(const edm4hep::TrackerHitCollection* col){m_hitColVec.push_back(col);}; | |||
| void AddTrackerAssociationCollection(const edm4hep::MCRecoTrackerAssociationCollection* col){m_assColVec.push_back(col);}; | |||
|
|
|||
| #if EDM4HEP_BUILD_VERSION <= EDM4HEP_VERSION(0, 10, 4) | |||
There was a problem hiding this comment.
I think this should have been (0, 10, 5), because the mentioned PR has not yet landed.
There was a problem hiding this comment.
@tmadlener and @jmcarcell sorry, I will create a new tag based one the new MR: #265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDM4hep plan to switch edm4hep::ObjectID to podio::ObjectID as key4hep/EDM4hep#260
Switch in code according to EDM4HEP_VERSION.
EDM4HEP_VERSION(0, 10, 2) maybe is not the last version has edm4hep::ObjectID, if not, and then it should be updated also.