feat: add 4 dimensional vector object

[osbornjd]

BEGINRELEASENOTES

• Added a Vector4f object for use as a general 4 dimensional vector with members x, y, z and t. Fixes Add 4D vector object #245

ENDRELEASENOTES

[tmadlener]

Thanks. I think this looks good with a few minor corrections.

There are some vector utilities that have been added by EIC here: utils/include/edm4hep/utils/vector_utils.h. I am not sure if you also want to add this one there, or if you want to wait with that until there is a need to do it.

Usually pre-commit will fail because the README.md has links to the different types in the YAML file and it checks whether they point to the right place. You can easily fix this via the scripts/updateReadmeLinks.py script.

[osbornjd]

There are some vector utilities that have been added by EIC here: utils/include/edm4hep/utils/vector_utils.h

I'll work on implementing some of these, as they would probably be useful in the long run

[osbornjd]

I added some basic operator functionality for the 4 vectors. I think that should be sufficient for now and if we need more functionality, I can come back and add it in a future PR.

[osbornjd]

What is the best way to test the build failure? This builds for me locally in my environment and all tests pass, so I'm not sure how best to debug. I did re-test with the precommit run --all-files and these seem to pass now

[tmadlener]

I think the build failures are in the c+17 builds. There is a vector_utils_legacy.h that get's dropped in in case there are no concepts available yet:

EDM4hep/utils/include/edm4hep/utils/vector_utils.h

Lines 6 to 8 in e481262

	#if !__cpp_concepts
	#include <edm4hep/utils/vector_utils_legacy.h>
	#else

So you would have to implement at least the vector_XYZ specializations for Vector4f there.

[osbornjd]

Looks like everything passes except that a test in an fcc build seg faults. What is the best way for me to test this locally as I don't see these tests in the repo?

[tmadlener]

That seems to be unrelated to this change and I am not entirely sure whether the downstream workflow is already supposed to be working. It has been a bit finicky in the past. For me this is as good as CI gets at the moment. Thanks for taking care of the legacy vector utils.

[osbornjd]

Okay sounds good, thanks for letting me know. In that case, if it is not too much of an issue would you mind creating a release after merging this PR? It is not urgent with the holidays coming up, so there is absolutely no rush on this

[tmadlener]

I will wait with merging until after the break even though this should not break anything. If nothing has happened after a few days in January, can you ping me again? A new tag is no problem.

[osbornjd]

Sounds great, will do. Thanks for your help!

[osbornjd]

Unless there are any further changes requested (and now since it is after the holiday break), are there any objections to merge this and create a new release?

[tmadlener]

There is a new tag and there is also a PR in spack to pick it up: spack/spack#41987

[osbornjd]

Thanks very much for the new tag!

[wdconinc]

Merged in spack.