feat: update vertex edm to 4d quantities #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also opened an issue here for including 4d vectors in edm4hep |
|
Opened a PR upstream for which this can eventually take advantage of |
|
@wdconinc this is ready to be merged now once we update to the new edm4hep version with key4hep/EDM4hep#248 merged. The CI here will naturally fail until we update edm4hep versions. |
|
wdconinc
reviewed
Jan 8, 2024
wdconinc
reviewed
Feb 2, 2024
wdconinc
reviewed
Feb 2, 2024
wdconinc
approved these changes
Feb 2, 2024
4 tasks
wdconinc
added a commit
that referenced
this pull request
Feb 7, 2024
### Briefly, what does this PR introduce? This was overlooked in the #61. ### What kind of change does this PR introduce? - [x] Bug fix (issue: edm4hep-0.10.2 doesn't work anymore) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR modifies the vertex EDM to contain 4D information, which is going to be needed in our streaming readout environment to separate pile up from physics bunch crossings.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Discussed in S&C meeting on the 18th of October here.
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?
It changes the vertex object for which the vertexing algorithm in EICRecon will need to be updated. This should be a simple fix since nothing else depends on the vertexing algorithm at the moment as it is still under development.