Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: no-op commit #4

Closed
wants to merge 70 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
eccfb0a
feat: convert v2 content libraries to use Learning Core models
ormsbee Oct 17, 2023
82d7a30
refactor: no need to spell out the app config when there's only one
ormsbee Feb 7, 2024
f79b3cd
chore: remove comment about libraries being blockstore-based
ormsbee Feb 7, 2024
21b7210
test: fix model tests for content_libraries
ormsbee Feb 7, 2024
8fd4718
test: remove unnecessary mixin layering of test; remove parent/child …
ormsbee Feb 7, 2024
ce2a10c
fix: fix the filtering test case (requires change from openedx-learning)
ormsbee Feb 7, 2024
d9ba5be
test: remove links-related tests (we no longer have them)
ormsbee Feb 7, 2024
952a3c3
test: remove tests regarding library-type conversion (we're no longer…
ormsbee Feb 7, 2024
a560c0c
test: more text patching
ormsbee Feb 7, 2024
cdb7a9f
fix: fix default xblock title behavior and adjust more tests
ormsbee Feb 8, 2024
5de9d46
fix: deleted blocks should 404 instead of 500
ormsbee Feb 8, 2024
3f6fcbc
feat!: remove blockstore lib import to learning core
ormsbee Feb 9, 2024
cbd3fe7
refactor: adjust openedx-learning usage to match 0.6.0 changes
ormsbee Feb 9, 2024
1583c25
test: fix content_tagging tests to remove blockstore collection use
ormsbee Feb 9, 2024
0b7ccac
test: remove test for v2 lib child block functionality (now unsupported)
ormsbee Feb 9, 2024
e0dca2a
test: remove blockstore usage from clipboard paste test
ormsbee Feb 9, 2024
7ce6bfc
fix: remove atomic decorator from views
ormsbee Feb 12, 2024
f52a332
refactor: shift library search logic from view to api
ormsbee Feb 12, 2024
51d69e5
fix: force content libraries views to be nonatomic
ormsbee Feb 13, 2024
cad1521
refactor: remove unnecessary imports
ormsbee Feb 13, 2024
706fa13
fix: have field data properly track changed fields (and simplify the …
ormsbee Feb 13, 2024
2168c5e
fix: remove error log that I was only using for debugging purposes
ormsbee Feb 13, 2024
78c8b48
refactor: cleanups, comments
ormsbee Feb 14, 2024
10ae9c5
refactor: more comment tweaks
ormsbee Feb 14, 2024
f96ef5f
refactor: more cleanup of config and removing debug comments
ormsbee Feb 14, 2024
c05ed88
refactor: more cleanup
ormsbee Feb 14, 2024
44af99a
refactor: remove unused imports
ormsbee Feb 14, 2024
cfe5a26
refactor: update comments
ormsbee Feb 14, 2024
6157bea
refactor: remove unnecessary atomic block
ormsbee Feb 14, 2024
1b6ebbe
refactor: add comments to api calls, remove unused function
ormsbee Feb 14, 2024
bb3cdfd
refactor: changes in response to Kyle's review
ormsbee Feb 14, 2024
3ba8479
refactor: consolidate get_component_from_usage_key implementations
ormsbee Feb 14, 2024
c4de68a
refactor: comment
ormsbee Feb 14, 2024
2cf37f7
refactor: remove get_block_display_name
ormsbee Feb 14, 2024
5cfbbd1
refactor: remove unnecessary config value for OPENEDX_LEARNING
ormsbee Feb 14, 2024
1eb2363
refactor: remove ENABLE_LIBRARY_AUTHORING_MICROFRONTEND from devstack…
ormsbee Feb 14, 2024
0baee71
fix: make schema migration more backwards-compatible
ormsbee Feb 14, 2024
746e0ee
fix: add LC models to keyword overrides (I'm checking now if this is …
ormsbee Feb 14, 2024
4e1205b
fix: address linter errors
ormsbee Feb 14, 2024
d5481bc
fix: more linter fixes
ormsbee Feb 14, 2024
cf1aed9
fix: more linter fixes
ormsbee Feb 14, 2024
e5e2a94
fix: all the linter things
ormsbee Feb 14, 2024
f2b3ac5
fix: spacing
ormsbee Feb 14, 2024
11e802f
fix: more linter fixes for indentation/spacing
ormsbee Feb 14, 2024
42670a0
fix: all the sytax linter stuff, I think...
ormsbee Feb 14, 2024
8c43d7c
fix: remove entries from db_keyword_overrides (no longer necessary)
ormsbee Feb 15, 2024
2ef2652
chore: mypy thinks it's a BaseManager and not a ContentLibraryManager
ormsbee Feb 15, 2024
53f0a33
fix: skip the libraries test cases under LMS (signals won't get sent)
ormsbee Feb 15, 2024
0f36be2
refactor: re-order skip and ddt decorators in case that makes any dif…
ormsbee Feb 15, 2024
8c19357
refactor: address some minor review comments
kdmccormick Feb 16, 2024
1582c30
refactor: get_library_block_olx -> get_block_draft_olx
kdmccormick Feb 16, 2024
21caa2e
test: use OpenEdxEventsTestMixin to fix content_libraries event testing
kdmccormick Feb 16, 2024
1787959
fix: raise a ValueError if block is set to OLX with the wrong XML tag
kdmccormick Feb 16, 2024
de72774
fix: wrap _create_component_for_block in a transaction
kdmccormick Feb 16, 2024
da3a49c
test: use non-ascii characters in library org, slug, and block id
kdmccormick Feb 16, 2024
0d8ecb1
refactor: don't import MediaType from models
kdmccormick Feb 16, 2024
12f138b
fix: fall back to type-defined block name if display_name missing
kdmccormick Feb 16, 2024
47cd922
fix: typo in get_block_display_name
kdmccormick Feb 20, 2024
2b95faf
test: fix non-ascii content_libraries tests
kdmccormick Feb 20, 2024
9ffa28d
refactor: component_already_exists -> _component_exists
kdmccormick Feb 21, 2024
60563aa
docs: add TODO comments - draft vs published, and deserialization
kdmccormick Feb 21, 2024
be1cacc
Merge remote-tracking branch 'upstream/master' into learning-core-lib…
kdmccormick Feb 21, 2024
3b48aa2
feat: allow non-ascii block ids
kdmccormick Feb 21, 2024
c4a2c5c
feat!: rm get_library_blocks
kdmccormick Feb 21, 2024
7f65299
Merge remote-tracking branch 'upstream/master' into learning-core-lib…
kdmccormick Feb 21, 2024
47756a5
fix: typo -- left something commented out while testing
kdmccormick Feb 21, 2024
76f8778
fix: `only` was conflicting with `select_related`
kdmccormick Feb 21, 2024
9829f60
fix: final review comments
kdmccormick Feb 21, 2024
91b330c
temp: noop
kdmccormick Feb 21, 2024
4a32dc2
Merge branch 'learning-core-libs-readwrite-runtime' into kdmccormick/…
kdmccormick Feb 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove error log that I was only using for debugging purposes
  • Loading branch information
ormsbee authored and kdmccormick committed Feb 20, 2024
commit 2168c5e69017ec23f13ccf4b3f34451c0c6a78b1
2 changes: 0 additions & 2 deletions openedx/core/djangoapps/xblock/api.py
Original file line number Diff line number Diff line change
@@ -97,8 +97,6 @@ def load_block(usage_key, user):
# Get the Learning Context Implementation based on the usage key
context_impl = get_learning_context_impl(usage_key)

log.error(f"load_block using {context_impl} for {usage_key}")

# Now, check if the block exists in this context and if the user has
# permission to render this XBlock view:
if user is not None and not context_impl.can_view_block(user, usage_key):