Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp: no-op commit #4

Closed
wants to merge 70 commits into from
Closed

temp: no-op commit #4

wants to merge 70 commits into from

Conversation

kdmccormick
Copy link
Owner

No description provided.

@kdmccormick kdmccormick force-pushed the kdmccormick/noop branch 4 times, most recently from 6962ade to 27910c2 Compare February 13, 2024 19:25
ormsbee added 26 commits February 20, 2024 10:22
@ormsbee @kdmccormick
feat: convert v2 content libraries to use Learning Core models
eccfb0a
@ormsbee @kdmccormick
refactor: no need to spell out the app config when there's only one
82d7a30
@ormsbee @kdmccormick
chore: remove comment about libraries being blockstore-based
f79b3cd
@ormsbee @kdmccormick
test: fix model tests for content_libraries
21b7210
@ormsbee @kdmccormick
test: remove unnecessary mixin layering of test; remove parent/child …
8fd4718 
…tests

(we don't support that)
@ormsbee @kdmccormick
fix: fix the filtering test case (requires change from openedx-learning)
ce2a10c
@ormsbee @kdmccormick
test: remove links-related tests (we no longer have them)
d9ba5be
@ormsbee @kdmccormick
test: remove tests regarding library-type conversion (we're no longer…
952a3c3 
… supporting that).
@ormsbee @kdmccormick
test: more text patching
a560c0c
@ormsbee @kdmccormick
fix: fix default xblock title behavior and adjust more tests
cdb7a9f
@ormsbee @kdmccormick
fix: deleted blocks should 404 instead of 500
5de9d46
@ormsbee @kdmccormick
feat!: remove blockstore lib import to learning core
3f6fcbc 
There are no live v2 blockstore libraries that we're planning to
migrate.
@ormsbee @kdmccormick
refactor: adjust openedx-learning usage to match 0.6.0 changes
cbd3fe7
@ormsbee @kdmccormick
test: fix content_tagging tests to remove blockstore collection use
1583c25
@ormsbee @kdmccormick
test: remove test for v2 lib child block functionality (now unsupported)
0b7ccac
@ormsbee @kdmccormick
test: remove blockstore usage from clipboard paste test
e0dca2a
@ormsbee @kdmccormick
fix: remove atomic decorator from views
7ce6bfc
@ormsbee @kdmccormick
refactor: shift library search logic from view to api
f52a332
@ormsbee @kdmccormick
fix: force content libraries views to be nonatomic
51d69e5
@ormsbee @kdmccormick
refactor: remove unnecessary imports
cad1521
@ormsbee @kdmccormick
fix: have field data properly track changed fields (and simplify the …
706fa13 
…runtime/fielddata)
@ormsbee @kdmccormick
fix: remove error log that I was only using for debugging purposes
2168c5e
@ormsbee @kdmccormick
refactor: cleanups, comments
78c8b48
@ormsbee @kdmccormick
refactor: more comment tweaks
10ae9c5
@ormsbee @kdmccormick
refactor: more cleanup of config and removing debug comments
f96ef5f
@ormsbee @kdmccormick
refactor: more cleanup
c05ed88
ormsbee and others added 25 commits February 20, 2024 10:47
@ormsbee @kdmccormick
fix: more linter fixes for indentation/spacing
11e802f
@ormsbee @kdmccormick
fix: all the sytax linter stuff, I think...
42670a0
@ormsbee @kdmccormick
fix: remove entries from db_keyword_overrides (no longer necessary)
8c43d7c
@ormsbee @kdmccormick
chore: mypy thinks it's a BaseManager and not a ContentLibraryManager
2ef2652
@ormsbee @kdmccormick
fix: skip the libraries test cases under LMS (signals won't get sent)
53f0a33
@ormsbee @kdmccormick
refactor: re-order skip and ddt decorators in case that makes any dif…
0f36be2 
…ference
@kdmccormick
refactor: address some minor review comments
8c19357 
* specify 'draft' in docstring for get_library_block
* make create_component_for_block private
* delete leftover get_learning_context_impl comment
@kdmccormick
refactor: get_library_block_olx -> get_block_draft_olx
1582c30
@kdmccormick
test: use OpenEdxEventsTestMixin to fix content_libraries event testing
21caa2e 
I'm not going to pretend I entirely understand this, but I'd like to get
tests passing first, and then worry about the details.
@kdmccormick
fix: raise a ValueError if block is set to OLX with the wrong XML tag
1787959
@kdmccormick
fix: wrap _create_component_for_block in a transaction
de72774
@kdmccormick
test: use non-ascii characters in library org, slug, and block id
da3a49c
@kdmccormick
refactor: don't import MediaType from models
0d8ecb1
@kdmccormick
fix: fall back to type-defined block name if display_name missing
12f138b
@kdmccormick
fix: typo in get_block_display_name
47cd922
@kdmccormick
test: fix non-ascii content_libraries tests
2b95faf
@kdmccormick
refactor: component_already_exists -> _component_exists
9ffa28d
@kdmccormick
docs: add TODO comments - draft vs published, and deserialization
60563aa
@kdmccormick
Merge remote-tracking branch 'upstream/master' into learning-core-lib…
be1cacc 
…s-readwrite-runtime
@kdmccormick
feat: allow non-ascii block ids
3b48aa2
@kdmccormick
feat!: rm get_library_blocks
c4a2c5c
@kdmccormick
Merge remote-tracking branch 'upstream/master' into learning-core-lib…
7f65299 
…s-readwrite-runtime
@kdmccormick
fix: typo -- left something commented out while testing
47756a5
@kdmccormick
fix: only was conflicting with select_related
76f8778
@kdmccormick
fix: final review comments
9829f60
@kdmccormick kdmccormick deleted the kdmccormick/noop branch October 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdmccormick @ormsbee