propper svg/math elements #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotre
requested changes
Oct 16, 2023
geotre
approved these changes
Oct 20, 2023
|
Looks great. Good job @choltreppe |
This was referenced Oct 20, 2023
Closed
daylinmorgan
pushed a commit
to daylinmorgan/karax
that referenced
this pull request
Aug 28, 2024
* propper svg/math elements * make namespaces var * simplify toTag/toEventName defs, and dont uppercase toTag * fix class-name update of svg elements
daylinmorgan
pushed a commit
to daylinmorgan/karax
that referenced
this pull request
Sep 14, 2024
* propper svg/math elements * make namespaces var * simplify toTag/toEventName defs, and dont uppercase toTag * fix class-name update of svg elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, so here it is. I did the same test as in the .yml file so it should be all good.
edit: I ticked the version number, hope thats correct