Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ember upgrade attempt v5.12 #2258

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

ValenberghsSven
Copy link
Contributor

https://kanselarij.atlassian.net/browse/KAS-4924

v5.8 to v5.12

  • fixed unnecessary braces in templates (linter error)
  • added 3 rules to linter:
  • we should stop using @ember/runloop
  • we should stop using {{did-insert}} and {{did-update}}, need alternative or custom implementation
  • we should look at places where we use args to update tracked properties.

Other than those, upgrade went smoothly

Base automatically changed from feature/ember-upgrade-attempt-v5.8 to development November 28, 2024 15:34
@ValenberghsSven
Copy link
Contributor Author

No major breaking tests, only known flakys

@ValenberghsSven ValenberghsSven marked this pull request as ready for review November 28, 2024 15:34
@ValenberghsSven ValenberghsSven merged commit 98fc665 into development Nov 28, 2024
1 of 2 checks passed
@ValenberghsSven ValenberghsSven deleted the feature/ember-upgrade-attempt-v5.12 branch November 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant