Merge pull request #2258 from kanselarij-vlaanderen/feature/ember-upg…

…rade-attempt-v5.12

Feature/ember upgrade attempt v5.12

.eslintrc.js

@@ -29,6 +29,8 @@ module.exports = {
       { argsIgnorePattern: '^_' },
     ],
     'no-dupe-class-members': 'off',
+    'ember/no-runloop': 'off',
+    'ember/no-tracked-properties-from-args': 'off',
   },
   overrides: [
     // node files

.template-lintrc.cjs

@@ -7,5 +7,6 @@ module.exports = {
     // We like to handle the most common branch in the first clause, which is
     // why the first clause has a negated condition some times.
     'no-negated-condition': 'off',
+    'no-at-ember-render-modifiers': 'off',
   },
 };

app/components/agenda/formally-ok-edit.hbs

@@ -16,7 +16,7 @@
     @disabled={{this.onSave.isRunning}}
   as |option|>
     {{#if option.svg }}
-      <AuIcon @icon={{option.svg.icon}} class={{(concat "au-u-" option.svg.color)}} />
+      <AuIcon @icon={{option.svg.icon}} class={{concat "au-u-" option.svg.color}} />
     {{/if}}
     {{option.label}}
   </PowerSelect>

app/components/agenda/side-nav/agenda.hbs

@@ -1,7 +1,7 @@
 <Auk::TabExpanded
   data-test-agenda-side-nav-agenda
   @route="agenda.agendaitems"
-  @current-when={{(eq @currentAgenda.id @agenda.id)}} {{!-- as by LinkTo specs, @current-when can also be a boolean, which is needed here --}}
+  @current-when={{eq @currentAgenda.id @agenda.id}} {{!-- as by LinkTo specs, @current-when can also be a boolean, which is needed here --}}
   @models={{array @meeting.id @agenda.id}}
 >
   {{#if @isOpen}}

app/components/documents/document-preview/document-preview-modal.hbs

@@ -18,7 +18,7 @@
             data-test-document-preview-download-link
             @icon="download"
             @iconAlignment="left"
-            @hideText={{(responsive "isMobile")}}
+            @hideText={{responsive "isMobile"}}
             href={{this.downloadLink}}
             class="auk-u-mr-2"
             download

app/components/utils/formally-ok-selector.hbs

@@ -14,7 +14,7 @@
     class="auk-u-min-width-medium"
   as |option|>
     {{#if option.svg }}
-      <AuIcon @icon={{option.svg.icon}} class={{(concat "au-u-" option.svg.color)}} />
+      <AuIcon @icon={{option.svg.icon}} class={{concat "au-u-" option.svg.color}} />
     {{/if}}
     {{option.label}}
   </PowerSelect>

config/ember-cli-update.json

@@ -3,15 +3,16 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "5.8.0",
+      "version": "5.12.0",
       "blueprints": [
         {
           "name": "app",
           "outputRepo": "https://github.com/ember-cli/ember-new-output",
           "codemodsSource": "ember-app-codemods-manifest@1",
           "isBaseBlueprint": true,
           "options": [
-            "--no-welcome"
+            "--no-welcome",
+            "--ci-provider=none"
           ]
         }
       ]

cypress/support/commands/case-commands.js

@@ -135,21 +135,21 @@ function addSubcaseViaModal(subcase) {
   const randomInt = Math.floor(Math.random() * Math.floor(10000));
 
   cy.log('addSubcaseViaModal');
+  cy.intercept('GET', '/government-bodies**').as(`getGovernmentBodies${randomInt}`);
+  cy.intercept('GET', '/mandatees**').as(`getMandatees${randomInt}`);
   cy.intercept('POST', '/subcases').as(`createNewSubcase${randomInt}`);
   cy.intercept('POST', '/meetings/*/submit').as(`submitToMeeting${randomInt}`);
   cy.intercept('POST', '/submission-activities').as(`postSubmissionActivities${randomInt}`);
-  cy.intercept('GET', '/mandatees**').as(`getMandatees${randomInt}`);
-  cy.intercept('GET', '/government-bodies**').as(`getGovernmentBodies${randomInt}`);
 
   // after creating a case we are already on the page to add a subcase
   if (!subcase.newCase) {
     cy.get(cases.subcaseOverviewHeader.openAddSubcase).click();
   }
 
-  cy.wait(`@getMandatees${randomInt}`, {
+  cy.wait(`@getGovernmentBodies${randomInt}`, {
     timeout: 60000,
   });
-  cy.wait(`@getGovernmentBodies${randomInt}`, {
+  cy.wait(`@getMandatees${randomInt}`, {
     timeout: 60000,
   });