Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved python module architecture and added algos. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved python module architecture and added algos. #2

wants to merge 1 commit into from

Conversation

KOLANICH
Copy link
Contributor

  • Splitted core and algos
  • Introduced a new API
  • Added zstd, brotli and bzip
  • Added paramaters for all algos

@KOLANICH KOLANICH force-pushed the python_fixes branch 2 times, most recently from 9c7d7e1 to 3f3bb1b Compare July 15, 2019 23:56
@KOLANICH
Copy link
Contributor Author

@GreyCat, any progress merging this?

@GreyCat
Copy link
Member

GreyCat commented Jul 20, 2019

Currently, run-python in tests fails with:

ascii_text
Traceback (most recent call last):
  File "./test-python.py", line 33, in <module>
    obj = test_class.from_file('compressed/%s.%s' % (name, ext))
  File "$HOME/.local/lib/python3.7/site-packages/kaitaistruct.py", line 35, in from_file
    return cls(KaitaiStream(f))
  File "$HOME/git/kaitai_compress/_test/compiled/python/test_lz4.py", line 16, in __init__
    self._read()
  File "$HOME/git/kaitai_compress/_test/compiled/python/test_lz4.py", line 20, in _read
    _process = kaitai.compress.Lz4()
  File "$HOME/git/kaitai_compress/python/kaitai/compress/algorithms/lz4.py", line 8, in __init__
    self.obj = lz4.frame.LZ4FrameCompressor(block_size=block_size, block_linker=linker, compression_level=compression_level, content_checksum=frame_checksum, block_checksum=block_checksum, return_bytearray=False)
TypeError: __init__() got an unexpected keyword argument 'block_linker'

GreyCat
GreyCat reviewed Jul 20, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@KOLANICH KOLANICH mentioned this pull request Aug 19, 2019
Open
@KOLANICH KOLANICH mentioned this pull request Aug 3, 2020
Closed
@KOLANICH KOLANICH mentioned this pull request Sep 20, 2020
Open
@KOLANICH KOLANICH mentioned this pull request Jan 8, 2021
Open
@KOLANICH KOLANICH force-pushed the python_fixes branch 2 times, most recently from 3e8d981 to e4f4b77 Compare January 28, 2021 17:51
@KOLANICH KOLANICH force-pushed the python_fixes branch 3 times, most recently from 3e94b6e to a229d42 Compare August 30, 2021 17:12
@KOLANICH KOLANICH force-pushed the python_fixes branch 2 times, most recently from fee0ca2 to b860b00 Compare October 12, 2021 10:41
@KOLANICH
Improved python module architecture and added algos.
6525ac9 
* Splitted core and algos
* Introduced a new API
* Added zstd, brotli, snappy, lzham, implode and bzip
* Fixed brotli files extension
* Added paramaters for all the algos
* Some improvements in packaging.
* Improved testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreyCat GreyCat GreyCat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KOLANICH @GreyCat