Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for serialization #48

Closed
wants to merge 1 commit into from

Conversation

UserUnknownFactor
Copy link

It would be nice to have the python library prepared for serialization functionality.

@KOLANICH
Copy link
Contributor

KOLANICH commented Aug 3, 2020

#13 and #12 are related

kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
Copy link
Contributor

@KOLANICH KOLANICH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In its current state it is inacceptable to be merged.

kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
@UserUnknownFactor
Copy link
Author

Example of code: #48 (comment)
Also do KaitaiStructs runtime needs __init__ mention the stuff?
Because currently compiler creates code that doesn't call super anyway.

@UserUnknownFactor
Copy link
Author

I removed all changes related to possible compiler implementation and alignment, I'll do them as a separate PRs.

kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
Copy link
Member

@generalmimon generalmimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I request some changes in the comments above.

@UserUnknownFactor
Copy link
Author

This should be enough, right?

kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
kaitaistruct.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants