Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify the Spec with SuperuserSecretName, only the dcConfig. A… #1237

Merged
merged 2 commits into from
Mar 11, 2024

Remove commented out code, add CHANGELOG

04aa129
Select commit
Loading
Failed to load commit list.
Merged

Do not modify the Spec with SuperuserSecretName, only the dcConfig. A… #1237

Remove commented out code, add CHANGELOG
04aa129
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2024 in 1s

57.44% (+0.14%) compared to 6ad0ed0

View this Pull Request on Codecov

57.44% (+0.14%) compared to 6ad0ed0

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.44%. Comparing base (6ad0ed0) to head (04aa129).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   57.30%   57.44%   +0.14%     
==========================================
  Files         103      103              
  Lines       10794    10783      -11     
==========================================
+ Hits         6185     6194       +9     
+ Misses       4069     4054      -15     
+ Partials      540      535       -5     
Files Coverage Δ
pkg/secret/inject.go 76.19% <ø> (+3.46%) ⬆️
controllers/k8ssandra/dcconfigs.go 76.81% <50.00%> (+0.34%) ⬆️
controllers/k8ssandra/secrets.go 71.64% <83.33%> (+8.00%) ⬆️

... and 3 files with indirect coverage changes