Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify the Spec with SuperuserSecretName, only the dcConfig. A… #1237

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Mar 8, 2024

…lso, do not mount any secrets to cassandra container

What this PR does:

  • Do not modify the K8ssandraCluster object when superuserSecretName isn't set, instead set it at the dcConfig creation.
  • Remove injected secret from the cassandra container as it isn't used by anything.

Which issue(s) this PR fixes:
Fixes #1235

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

…lso, do not mount any secrets to cassandra container
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.44%. Comparing base (6ad0ed0) to head (04aa129).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   57.30%   57.44%   +0.14%     
==========================================
  Files         103      103              
  Lines       10794    10783      -11     
==========================================
+ Hits         6185     6194       +9     
+ Misses       4069     4054      -15     
+ Partials      540      535       -5     
Files Coverage Δ
pkg/secret/inject.go 76.19% <ø> (+3.46%) ⬆️
controllers/k8ssandra/dcconfigs.go 76.81% <50.00%> (+0.34%) ⬆️
controllers/k8ssandra/secrets.go 71.64% <83.33%> (+8.00%) ⬆️

... and 3 files with indirect coverage changes

@burmanm burmanm marked this pull request as ready for review March 8, 2024 13:41
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@burmanm burmanm requested a review from a team as a code owner March 8, 2024 13:41
@adejanovski adejanovski self-requested a review March 11, 2024 08:43
@adejanovski adejanovski merged commit 94bc1d8 into k8ssandra:main Mar 11, 2024
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8ssandraCluster Spec is modified the by operator
2 participants