Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commonAnnotations to Cassandra metadata #1094

Closed
ClusterJan opened this issue Oct 20, 2023 · 2 comments · Fixed by #1169
Closed

Add commonAnnotations to Cassandra metadata #1094

ClusterJan opened this issue Oct 20, 2023 · 2 comments · Fixed by #1169
Assignees
Labels
done Issues in the state 'done' enhancement New feature or request

Comments

@ClusterJan
Copy link

What is missing?

There should be a commonAnnotations field in the cassandra.metadata section of the ressource K8ssandraCluster.

Why do we need it?

Other operators in our Kubernetes cluster are interfering with the resources created by the cass-operator, and we need to add annotations to exclude these resources from the other operators.

Environment

  • K8ssandra Operator version:

    v1.9.1

Anything else we need to know?:
No.

@ClusterJan ClusterJan added the enhancement New feature or request label Oct 20, 2023
@andrejshapal
Copy link

Looks very usefull for argocd.

@adejanovski adejanovski moved this to Product Backlog in K8ssandra Oct 25, 2023
@adejanovski adejanovski added the product-backlog Issues in the state 'product-backlog' label Oct 25, 2023
@adejanovski adejanovski moved this from Product Backlog to Ready in K8ssandra Dec 15, 2023
@adejanovski adejanovski added ready Issues in the state 'ready' and removed product-backlog Issues in the state 'product-backlog' labels Dec 15, 2023
@Miles-Garnsey Miles-Garnsey mentioned this issue Dec 18, 2023
5 tasks
@Miles-Garnsey
Copy link
Member

Miles-Garnsey commented Dec 18, 2023

From discussions internally and reviewing the conversations on discord, it looks like what is being asked for here is annotations for the statefulset, pods etc. coming from cass-operator.

I was originally going to implement this in k8ssandra-operator, but

  1. Annotating the podTemplateSpec won't necessarily annotate the statefulSet itself.
  2. There is a preference amongst the rest of the team for adding an AdditionalAnnotations field in the cass-operator CRD instead of doing this via the podTemplateeSpec.

I'll raise a ticket on cass-operator first, then expose this in k8ssandra-operator as a second step. Note that this won't change annotations on other resources created by k8ssandra-operator, but my understanding is that fields already exist to control annotations for the other resources.

@adejanovski adejanovski moved this from Ready to In Progress in K8ssandra Jan 8, 2024
@adejanovski adejanovski added in-progress Issues in the state 'in-progress' and removed ready Issues in the state 'ready' labels Jan 8, 2024
@Miles-Garnsey Miles-Garnsey moved this from In Progress to Ready For Review in K8ssandra Jan 11, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed in-progress Issues in the state 'in-progress' labels Jan 11, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in K8ssandra Jan 16, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed ready-for-review Issues in the state 'ready-for-review' labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issues in the state 'done' enhancement New feature or request
Projects
No open projects
Archived in project
4 participants