-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional annotations #1169
Additional annotations #1169
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 57.06% 56.87% -0.20%
==========================================
Files 101 101
Lines 10433 10432 -1
==========================================
- Hits 5954 5933 -21
- Misses 3959 3974 +15
- Partials 520 525 +5
|
2d7deb3
to
29c0710
Compare
This should be good to go... There is one failing test but I don't think it is related - probably a flake but I'm re-running. |
Alex says:
|
Looks like we can't progress this as we don't have a cass-operator image right now due to CI failures. I don't know how to fix those so will put this on hold pending a new image being built. |
…s-Garnsey/k8ssandra-operator into feature/additionalAnnotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Approved, pending passing unit tests (I think it's just a flake and just re-ran them).
Manually tested one more time, but this looks good to go indeed. |
Quality Gate failedFailed conditions 5.9% Duplication on New Code (required ≤ 3%) |
What this PR does:
Exposes cass-operator's new AdditionalAnnotations field in the CRD.
Which issue(s) this PR fixes:
Fixes #1094
Checklist