Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional annotations #1169

Merged

Conversation

Miles-Garnsey
Copy link
Member

@Miles-Garnsey Miles-Garnsey commented Jan 11, 2024

What this PR does:

Exposes cass-operator's new AdditionalAnnotations field in the CRD.

Which issue(s) this PR fixes:
Fixes #1094

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@Miles-Garnsey Miles-Garnsey requested a review from a team as a code owner January 11, 2024 02:03
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f25850d) 57.06% compared to head (b4850e7) 56.87%.

❗ Current head b4850e7 differs from pull request most recent head c03fed1. Consider uploading reports for the commit c03fed1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   57.06%   56.87%   -0.20%     
==========================================
  Files         101      101              
  Lines       10433    10432       -1     
==========================================
- Hits         5954     5933      -21     
- Misses       3959     3974      +15     
- Partials      520      525       +5     
Files Coverage Δ
apis/k8ssandra/v1alpha1/k8ssandracluster_types.go 44.30% <ø> (ø)
pkg/cassandra/datacenter.go 66.31% <25.00%> (-0.45%) ⬇️

... and 6 files with indirect coverage changes

@Miles-Garnsey Miles-Garnsey force-pushed the feature/additionalAnnotations branch from 2d7deb3 to 29c0710 Compare January 11, 2024 04:31
@Miles-Garnsey
Copy link
Member Author

This should be good to go... There is one failing test but I don't think it is related - probably a flake but I'm re-running.

@Miles-Garnsey
Copy link
Member Author

Alex says:

  1. We need to add something like this so that we deploy the right cass-operator with the new fields.
  2. He wants an e2e test for the new field as well.

@Miles-Garnsey
Copy link
Member Author

Looks like we can't progress this as we don't have a cass-operator image right now due to CI failures. I don't know how to fix those so will put this on hold pending a new image being built.

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Approved, pending passing unit tests (I think it's just a flake and just re-ran them).

@Miles-Garnsey
Copy link
Member Author

Manually tested one more time, but this looks good to go indeed.

@Miles-Garnsey Miles-Garnsey merged commit 4f244a9 into k8ssandra:main Jan 16, 2024
9 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commonAnnotations to Cassandra metadata
2 participants