fix: improve running time of GitHub actions #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS6 runners are better suited to longer running jobs due to turn around time needed for refreshing a runner. Currently 15-30 minutes each. Small jobs will move back to using github runners to speed up the overall time for github actions to take. Tests requiring the build job, are moved to the same workflow to reduce the number of times we run the build job. Integration tests will be run on PS6 runners using a test parallelization of 10.
It is a duplication of github-check-merge-juju-terraform-provider-juju and the actual merge job, thus will be required to be successful.
Not all of the charms in the acceptance tests have arm64 versions. Only use the x64 self-hosted runners until new charms can be found.
hmlanigan
changed the title
alesstimec
approved these changes
Dec 6, 2024
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| terraform: ["1.7.*", "1.8.*", "1.9.*"] | ||
| terraform: ["1.9.*"] |
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving to self-hosted runners on PS6, the GitHub actions could take 1-2+ hours. Caused in part by how the runners were configured and how the GitHub actions were constructed.
The PS6 self-hosted runners are optimized for larger jobs. Turn around time on recreating a runner could be 15-30 minutes.
Steps taken in the optimization:
The matrix for running the integration tests has also been reduced in size by 2/3rds. Old versions of the terraform client will no longer be tested, only the most recent. We have never seen a difference in test results caused by different client versions.
Only the x64 runners will be used until the acceptance tests can be updated with new tests which run on both architectures.