Skip to content

Commit

Permalink
chore: optimize jobs for using PS6 runners
Browse files Browse the repository at this point in the history
PS6 runners are better suited to longer running jobs due to turn around
time needed for refreshing a runner. Currently 15-30 minutes each.

Small jobs will move back to using github runners to speed up the
overall time for github actions to take.

Tests requiring the build job, are moved to the same workflow to reduce
the number of times we run the build job.

Integration tests will be run on PS6 runners using a test
parallelization of 10.
  • Loading branch information
hmlanigan committed Nov 14, 2024
1 parent 66d016c commit d03e3a5
Show file tree
Hide file tree
Showing 8 changed files with 201 additions and 302 deletions.
114 changes: 0 additions & 114 deletions .github/workflows/build.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
# Ensure project builds before running testing matrix
build:
name: Build
runs-on: [self-hosted, jammy]
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/cla.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
name: "CLA check"
name: "Static Analysis"
on: [pull_request, workflow_dispatch]

permissions:
contents: read

# This task runs solo has it doesn't need to be run as often.
jobs:
cla-check:
permissions:
pull-requests: write # for canonical/has-signed-canonical-cla to create & update comments
runs-on: [self-hosted, jammy]
runs-on: ubuntu-latest
steps:
- name: Check if CLA signed
uses: canonical/[email protected]
with:
accept-existing-contributors: true

83 changes: 83 additions & 0 deletions .github/workflows/static-analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,93 @@ on:
permissions:
contents: read

# These jobs are small independent tasks which are required, but do not
# gate any integration or unit tests.
jobs:
# Ensure convention commits guidelines have been followed.
conventional-commits:
name: Check conventional commits
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: wagoid/commitlint-github-action@v6

# Ensure the generated docs are up-to-date
generate:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version-file: "go.mod"
cache: true
- uses: hashicorp/setup-terraform@v3
with:
terraform_version: "1.9.*"
terraform_wrapper: false
- run: go generate ./...
- name: git diff
run: |
git diff --compact-summary --exit-code || \
(echo; echo "Unexpected difference in directories after code generation. Run 'go generate ./...' command and commit."; exit 1)
# Ensure the go code is formatted properly
format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version-file: "go.mod"
cache: true
- run: gofmt -w -l -s .
- name: git diff
run: |
git diff --compact-summary --exit-code || \
(echo; echo "Unexpected difference in directories after go fmt. Run 'gofmt -w -l -s .' command and commit."; exit 1)
# This runs golangci-lint against the codebase
lint:
name: golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Determine which tests to run
uses: dorny/paths-filter@v3
id: filter
with:
filters: |
go:
- '**.go'
- 'go.mod'
- uses: actions/setup-go@v5
with:
go-version-file: "go.mod"
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.54.0
args: --print-issued-lines=true

# This runs copyright-check against the codebase
copyright-check:
name: copyright-check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version-file: "go.mod"
cache: false
- run: |
OUT=$(find . -name '*.go' | sort | xargs grep -L -E '// (Copyright|Code generated)' || true)
LINES=$(echo "${OUT}" | wc -w)
if [ "$LINES" != 0 ]; then
echo ""
echo "$(red 'Found some issues:')"
echo -e '\nThe following files are missing copyright headers'
echo "${OUT}"
exit 1
fi
126 changes: 0 additions & 126 deletions .github/workflows/test_add_machine.yml

This file was deleted.

Loading

0 comments on commit d03e3a5

Please sign in to comment.