Switch to importlib-metadata to drop deprecated pkg_resources #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a nice and rather simple change. It seems like the API is mostly compatible and it is a good further step in modernizing |
FantasqueX
force-pushed
the
switch-to-importlib-metadata
branch
from
a9f2b8c to
7f882e7
Compare
|
Thanks for the contribution @FantasqueX, and thanks for reviewing @maxz! Looks good to me, I just want to learn more about importlib before adding it as a requirement. |
According to https://setuptools.pypa.io/en/latest/pkg_resources.html, pkg_resources has been deprecated and importlib-metadata is recommended. `DistributionNotFound` only can be thrown from `find_plugins()` which is not used by ia. Tested with plugin https://github.com/JesseWeinstein/ia_recent. Closes: jjjake#613
FantasqueX
force-pushed
the
switch-to-importlib-metadata
branch
from
7f882e7 to
6bae1f2
Compare
cclauss
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://setuptools.pypa.io/en/latest/pkg_resources.html, pkg_resources has been deprecated and importlib-metadata is recommended.
DistributionNotFoundonly can be thrown fromfind_plugins()which is not used by ia. Tested with plugin https://github.com/JesseWeinstein/ia_recent.Closes: #613