Bump test suite to current versions #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPython 3.7, PyPy 3.7, and PyPy 3.8 are EOL and unsupported.
cclauss
approved these changes
Feb 17, 2024
cclauss
suggested changes
Feb 19, 2024
There was a problem hiding this comment.
we should add a dependency on
setuptools
This is the correct solution because distutils was removed in Python 3.12 and the Python Packaging Authority recommends adding setuptools to project dependencies.
|
Yeah, it's the correct solution – if we don't migrate away from |
|
Yes. #621 is a better approach. |
|
Looks like this got obsoleted by e84edd1 although that did not remove the old PyPy versions. I'll create a new PR for that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPython 3.7, PyPy 3.7, and PyPy 3.8 are EOL and unsupported.
The test on 3.12 currently fails. This is due to #613, and merging this PR should probably wait for #621 (or we should add a dependency on
setuptoolsuntil that is resolved, as mentioned in #613 (comment)).