Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at using Last-Modified header to set mtime #614

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

jjjake
Copy link
Owner

@jjjake jjjake commented Oct 24, 2023

This is in support of setting a valid mtime for files.xml.

@jjjake jjjake merged commit 8c6d9b1 into master Mar 28, 2024
20 checks passed
@jjjake jjjake deleted the last-mod-download branch March 28, 2024 20:02
ChlodAlejandro added a commit to ChlodAlejandro/internetarchive that referenced this pull request May 26, 2024
jjjake#614 moved skip checks to until after response headers have been
received, which drastically slows down the download process if
the file already exists or the file has an equal checksum. Since
the file name and checksum are already known prior to download,
these checks should remain at the start to avoid having to make
a request which would eventually be discarded anyway.
ChlodAlejandro added a commit to ChlodAlejandro/internetarchive that referenced this pull request May 26, 2024
jjjake#614 moved skip checks to until after response headers have been
received, which drastically slows down the download process if
the file already exists or the file has an equal checksum. Since
the file name and checksum are already known prior to download,
these checks should remain at the start to avoid having to make
a request which would eventually be discarded anyway.
ChlodAlejandro added a commit to ChlodAlejandro/internetarchive that referenced this pull request May 26, 2024
jjjake#614 moved skip checks to until after response headers have been
received, which drastically slows down the download process if
the file already exists or the file has an equal checksum. Since
the file name and checksum are already known prior to download,
these checks should remain at the start to avoid having to make
a request which would eventually be discarded anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant