Skip early when downloading existing file #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjjake#614 moved skip checks to until after response headers have been received, which drastically slows down the download process if the file already exists or the file has an equal checksum. Since the file name and checksum are already known prior to download, these checks should remain at the start to avoid having to make a request which would eventually be discarded anyway.
|
Looks good, thank you @ChlodAlejandro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#614 moved some skip checks to until after response headers have been received, which drastically slows down the download process if the file already exists or the file has an equal checksum.
Since whether existing files (
--ignore-existing) or matching checksums (--checksum) are to be skipped, file name, and checksum are all already known prior to needing information about the file through theLast-Modifiedheader, these checks should remain at the start to avoid having to make a request which would eventually be discarded anyway. This speeds upia downloadby skipping the (relatively long-running) blocking HTTP request and also stops the script from making numerous wasted requests to the Internet Archive, especially for runs which cover hundreds of files.