Payable Feature #2
Conversation
| private def extractPayableParams(statements: Seq[Statement], scope: Set[String] = Set.empty[String], payableFields: Set[String], payableParams: Set[String]): Set[String] = { | ||
| val names = statements.foldLeft(payableParams) { (current, statement) => | ||
| statement match { | ||
| case Send(destination, _, _) => current.union(extractVarNames(destination)) |
There was a problem hiding this comment.
If destination includes field references, won't those be added in here as well, not just parameters?
There was a problem hiding this comment.
Just to clarify, is this if destination is of type struct? If so, yeah that's correctly, I'll be have to mindful of that when parsing and figuring out which variable within the struct's fields should be payable.
There was a problem hiding this comment.
I was just pointing out that this method is called extractPayableParams but here, when you use extractVarNames on destination, I don't think it would properly distinguish between fields and parameters.
There was a problem hiding this comment.
Ohh gotcha, yes yes that makes sense. Before I think the resolution was that I'd just union it with the set of parameters of that transition, but admittedly that's not a very good solution. For the current version, I check for whether the variable is a parameter or field before adding it 👍
[WIP] Adding payable keyword generation to Solidity generator of compiler. Changes include
To do / push: