-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move self_logand to the logical_and callable #1959
base: main
Are you sure you want to change the base?
Conversation
af4d016
to
b0012c1
Compare
da4a721
to
e10f67e
Compare
48d1d7b
to
9e3c740
Compare
While attempting to fix this callable for the "no simd" configurations, I encountered the following problem: auto test(logical<short> a, logical<wide<int>> b) {
return logical_and(a, b);
} Because of the rules defined by The current fix involves using a |
This would also improve compile time by not having a convoluted map result computation. |
waiting on the map2 branch |
EVE_FORCEINLINE logical<wide<T, N>> logical_and_(EVE_REQUIRES(sve_), O const&, logical<wide<T, N>> v, logical<wide<U, N>> w) noexcept | ||
requires(sve_abi<abi_t<T, N>> || sve_abi<abi_t<U, N>>) | ||
{ | ||
return svmov_z(v, convert(w, as<logical<T>>{})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem right anymore. I appreciate that you might not had time to fix it and this is a draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How so ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type shouldn't change based on what logical is first
After some talking we decided to change the behaviour of This is a breaking change. |
fe64b25
to
c7bdc8a
Compare
73fbf38
to
6090b71
Compare
No description provided.