Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New configRoundtrip method for Cloud configuration #426

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

sparsick
Copy link
Contributor

@sparsick sparsick commented Apr 22, 2022

In Jenkins plugin azure-container-plugin, there is a use case to test the correctness of the cloud configuration. The JenkinsRule has no configRoundtrip method for the cloud configuration.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja requested a review from jglick April 22, 2022 11:07
@jglick jglick changed the title New configRoundtrip method for cloud configuration New configRoundtrip method for Cloud configuration Apr 22, 2022
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. To prove that the API can be (and will be) used as written, you should create a draft PR in whatever plugin calling this method. (Include the URL of this PR in the Description to create a backlink.) Look up the incremental version number of this PR (see the Checks tab) and in your draft plugin PR add to <properties> in pom.xml

<jenkins-test-harness.version>1234.vwhatever</jenkins-test-harness.version> <!-- TODO https://github.com/jenkinsci/jenkins-test-harness/pull/426 -->

If your plugin has not yet been “incrementalified” then also

mkdir .mvn
echo -Pconsume-incrementals > .mvn/maven.config
git add .mvn

@jglick
Copy link
Member

jglick commented Apr 22, 2022

(just awaiting downstream PR)

@sparsick
Copy link
Contributor Author

Downstream PR is created jenkinsci/azure-container-agents-plugin#132

@jglick jglick merged commit 9bad176 into jenkinsci:master Apr 22, 2022
@sparsick sparsick deleted the configRoundtripForCloud branch April 25, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants