-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New configRoundtrip
method for Cloud
configuration
#426
Conversation
configRoundtrip
method for Cloud
configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right. To prove that the API can be (and will be) used as written, you should create a draft PR in whatever plugin calling this method. (Include the URL of this PR in the Description to create a backlink.) Look up the incremental version number of this PR (see the Checks tab) and in your draft plugin PR add to <properties>
in pom.xml
<jenkins-test-harness.version>1234.vwhatever</jenkins-test-harness.version> <!-- TODO https://github.com/jenkinsci/jenkins-test-harness/pull/426 -->
If your plugin has not yet been “incrementalified” then also
mkdir .mvn
echo -Pconsume-incrementals > .mvn/maven.config
git add .mvn
Co-authored-by: Jesse Glick <[email protected]>
Co-authored-by: Jesse Glick <[email protected]>
(just awaiting downstream PR) |
Downstream PR is created jenkinsci/azure-container-agents-plugin#132 |
In Jenkins plugin azure-container-plugin, there is a use case to test the correctness of the cloud configuration. The JenkinsRule has no configRoundtrip method for the cloud configuration.