Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring configuration test #132

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sparsick
Copy link
Contributor

@sparsick sparsick commented Apr 22, 2022

Refactoring of configuration tests

jenkinsci/jenkins-test-harness#426

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer indeed!

I will merge the upstream PR, which if all goes well should trigger a release of jenkins-test-harness. At that point you can bump the version here and take it out of draft. Or you can wait for Dependabot to offer the new version as a default in plugin-pom, and for that to be merged and at some point released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants