grass, grass-dev: use libgomp for OpenMP support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jürgen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building GRASS with both libgomp (supplied by
mingw-w64-x86_64-gcc) and libomp (withmingw-w64-x86_64-openmpfor Clang and LLVM) causes conflict. This was discussed at e.g. OSGeo/grass#4443.This PR removes the addition of the mingw-w64-x86_64-openmp package dependency and the patches related to OpenMP are removed.
(I have no means to test this, but these changes should be right).
Side note: there is a PR OSGeo/grass#4716 related to libopenblas which will be needed to account for (for
grass-dev) when merged.