Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: build Windows with libopenblas #4716

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Nov 19, 2024

Build Windows package with libopenblas, this addresses a missing change of d5bb442.

As tested and reported with #4485.

@nilason nilason added this to the 8.5.0 milestone Nov 19, 2024
@github-actions github-actions bot added the windows Microsoft Windows specific label Nov 19, 2024
@echoix
Copy link
Member

echoix commented Nov 19, 2024

Note that our CI doesn't test this. It uses the other script. That's why I had a separate PR in my fork for it. echoix#286 and echoix#285

@nilason
Copy link
Contributor Author

nilason commented Nov 19, 2024

What is broken, can’t be broken. ;)
I’m confident of these changes.

@echoix
Copy link
Member

echoix commented Nov 19, 2024

What is broken, can’t be broken. ;)

I’m confident of these changes.

Haha, I like that!

@nilason
Copy link
Contributor Author

nilason commented Nov 19, 2024

The OpenMP fix jef-n/OSGeo4W#24 is merged, this one remains to be merged (and relevant changes added to https://github.com/jef-n/OSGeo4W). With these changes, the Win build will hopefully (and probably) be working again. Please consider approve this, as to be able to find out as soon as possible with next build attempt.

@echoix
Copy link
Member

echoix commented Nov 19, 2024

This will probably break the patch from grass-dev too, so we might not get a new build for grass-dev
Sorry I didn't see that both grass and grass-dev were changed, I only saw grass

@nilason
Copy link
Contributor Author

nilason commented Nov 19, 2024

Thanks!

(The OpenMP fix is for both main and releasebranch_84, this OpenBLAS fix is for main only.)

@nilason nilason merged commit 9984205 into OSGeo:main Nov 19, 2024
27 checks passed
@nilason nilason deleted the fix_openblas_win branch November 19, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants