Optimized to increase UI performance #26
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jamesmontemagno, I'd like to thank you for sharing the ORC here.
In my use case I have a large collection that changes upon user key strokes (meaning: it 5-10 times a second), and the ORC you shared was still a bit laggy, so I decided to optimize it and added some of the following features.
I'd really hope if you can accept my PR so other people can benefit.
RemoveRange
action was throwing exceptions and caused UI issues when calling withNotifyCollectionChangedAction.Remove
. I hence updated theRemoveRange
to raise a separate remove event for each consecutive item cluster in the ORC, which dramatically improved the performanceReplaceRange
to allow for reusing existing elements or at least retain their index and just updating the element, and only raise events (batched when possible - unfortunately,Raplace
is not allowed for multiple items). More events costs way less performance than resetting items or not reusing them.