Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InsertRange #22

Closed
wants to merge 3 commits into from
Closed

Added InsertRange #22

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2017

Insert a collection in the specified index keeping the order of the specified collection

Bryan Sanchez added 3 commits June 13, 2017 14:49
Insert a collection in the specified index keeping the order of the specified collection
@ghost
Copy link
Author

ghost commented Jun 13, 2017

I dont know why AppVeyor is failing :((((( heeeeeeeelpppp

@jamesmontemagno
Copy link
Owner

You can see the build logs here:

ObservableRangeCollection.cs(131,106): error CS0305: Using the generic type 'IList' requires 1 type arguments [C:\projects\mvvm-helpers\MvvmHelpers\MvvmHelpers.csproj]
ObservableRangeCollection.cs(131,124): error CS1503: Argument 3: cannot convert from 'int' to 'System.Collections.IList' [C:\projects\mvvm-helpers\MvvmHelpers\MvvmHelpers.csproj]
0 Warning(s)
2 Error(s)

@jamesmontemagno
Copy link
Owner

There is a lot more error handling that would need to be implemented here such as the index being under or over.

@weitzhandler
Copy link

@jamesmontemagno
I can do it.
Can you please first take a look and review/accept my PR? #26

@jamesmontemagno
Copy link
Owner

Closing as out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants