Add automatic mana allotment #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 6, 2024 14:48
…taledger/iota-sdk into feat/automatic-mana-allotment
|
Tests are failing because they do not account for mana needed to allot the block. This could be fixed in two ways:
Either way, I'd appreciate it if this was reviewed now, so I'm leaving it undrafted. |
Thoralf-M
reviewed
Feb 7, 2024
Thoralf-M
reviewed
Feb 8, 2024
Thoralf-M
reviewed
Feb 8, 2024
Thoralf-M
reviewed
Feb 8, 2024
Thoralf-M
reviewed
Feb 9, 2024
sdk/src/client/api/block_builder/input_selection/requirement/allotment.rs
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Feb 9, 2024
sdk/src/client/api/block_builder/input_selection/requirement/allotment.rs
Outdated
Show resolved
Hide resolved
DaughterOfMars
force-pushed
the
feat/automatic-mana-allotment
branch
from
ff700be
to
6569ccf
Compare
added 2 commits
February 15, 2024 13:45
sdk/src/client/api/block_builder/input_selection/requirement/amount.rs
Outdated
Show resolved
Hide resolved
thibault-martinez
previously approved these changes
Feb 15, 2024
DaughterOfMars
dismissed stale reviews from Thoralf-M and thibault-martinez
via
c24587a
Thoralf-M
reviewed
Feb 15, 2024
thibault-martinez
approved these changes
Feb 15, 2024
Thoralf-M
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds automatic mana allotment to ISA. These changes move the context input addition to a new requirement, as well as adds the mana allotment requirement. In order to facilitate these changes, the slot index was upgraded to a slot commitment ID and input selection now requires an issuer ID. This also means that an issuer ID is now required to prepare a transaction. The reason for this is that we must be able to put the new allotments on the proper mana allotment, or else create one with the issuer ID. If we did not, we could not be certain that the resulting work score would be correct.
The reference work score must also be passed into ISA now in order to calculate the correct mana balance between the inputs and outputs.
In the process of making the changes, I found that it seems to be a simpler change to loop over the last two requirements for
ManaandAllotmentuntil no more inputs are needed.Links to any relevant issues
Closes #1816