Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move delegation code out of ISA #1937

Closed
thibault-martinez opened this issue Feb 2, 2024 · 4 comments
Closed

Move delegation code out of ISA #1937

thibault-martinez opened this issue Feb 2, 2024 · 4 comments
Assignees
Labels
m-wallet Module - Wallet t-cleanup Task - Cleanup

Comments

@thibault-martinez
Copy link
Member

Was put there because we need the issuance but that should be solved later when we have finished the block/tx options refactoring.

@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Feb 2, 2024
@thibault-martinez thibault-martinez added m-wallet Module - Wallet t-cleanup Task - Cleanup labels Feb 2, 2024
@thibault-martinez thibault-martinez added this to the v2.0.0 (Q1 2024) milestone Feb 2, 2024
@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Feb 5, 2024
@Alex6323 Alex6323 moved this from Sprint Backlog to In Progress in iota-sdk Feb 27, 2024
@Alex6323
Copy link
Contributor

Alex6323 commented Mar 1, 2024

build_transaction.rs was deleted in #1961, so this issue can be closed?

@Alex6323 Alex6323 moved this from In Progress to In Review in iota-sdk Mar 1, 2024
@thibault-martinez
Copy link
Member Author

It hasn't been deleted, it's been moved. This code still exists in input_selection/requirement/context_inputs.rs so this issue can't be closed.

@Alex6323
Copy link
Contributor

Alex6323 commented Mar 1, 2024

sure, but shouldn't we at least change the title of the issue then?

@thibault-martinez thibault-martinez changed the title Move delegation code out of build_transaction.rs Move delegation code out of ISA Mar 1, 2024
@Alex6323 Alex6323 moved this from In Review to In Progress in iota-sdk Mar 1, 2024
@Alex6323 Alex6323 linked a pull request Mar 1, 2024 that will close this issue
@thibault-martinez
Copy link
Member Author

We won't do this in the end, it's fine the way it is now.

@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-sdk Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-wallet Module - Wallet t-cleanup Task - Cleanup
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants