Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup ExportStrongholdButton #7250

Merged
merged 5 commits into from
Aug 19, 2023

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7249

Changelog

- cleanup ExportStrongholdButton

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

VmMad
VmMad previously requested changes Jul 24, 2023
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Props have weird names imo

@evavirseda evavirseda requested a review from VmMad July 25, 2023 07:12
packages/desktop/views/dashboard/settings/views/security/ExportStronghold.svelte
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ

@begonaalvarezd begonaalvarezd dismissed VmMad’s stale review August 19, 2023 17:05

props are corrected

@begonaalvarezd begonaalvarezd merged commit 26f947a into develop Aug 19, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/cleanup-exportStrongholdButton branch August 19, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup ExportStrongholdButton
4 participants