refactor: cleanup ExportStrongholdButton (#7250)

* refactor: cleanup component * refactor: rename props --------- Co-authored-by: Jean Carlo Noguera <[email protected]> Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
iotaledger · Aug 19, 2023 · 26f947a · 26f947a
1 parent f8df16f
commit 26f947a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/desktop/components/popups/BackupStrongholdPopup.svelte b/packages/desktop/components/popups/BackupStrongholdPopup.svelte
@@ -29,6 +29,6 @@
         <Button outline classes="w-1/2" onClick={onCancelClick} disabled={busy}>
             {localize('actions.cancel')}
         </Button>
-        <ExportStrongholdButton showNotification overrideTitle={localize('actions.backup')} classes="w-1/2" />
+        <ExportStrongholdButton showNotification title={localize('actions.backup')} classes="w-1/2" />
     </div>
 </div>
diff --git a/packages/desktop/views/dashboard/settings/views/security/ExportStronghold.svelte b/packages/desktop/views/dashboard/settings/views/security/ExportStronghold.svelte
@@ -2,7 +2,7 @@
     import { ExportStrongholdButton, Spinner, Text, TextType } from 'shared/components'
     import { localize } from '@core/i18n'
 
-    let isBusy = false
+    let isBusy: boolean = false
     let message: string = ''
 </script>
 

diff --git a/packages/shared/components/buttons/ExportStrongholdButton.svelte b/packages/shared/components/buttons/ExportStrongholdButton.svelte
@@ -5,12 +5,12 @@
     import { openPopup, PopupId } from '@auxiliary/popup'
     import { Button, ButtonSize } from 'shared/components'
 
-    export let isBusy = false
-    export let message = ''
-    export let showNotification = false
-    export let overrideTitle = ''
+    export let isBusy: boolean = false
+    export let message: string = ''
+    export let showNotification: boolean = false
+    export let title: string = ''
 
-    function handleExportStrongholdResponse(cancelled, error): void {
+    function handleExportStrongholdResponse(cancelled: boolean, error: string | undefined): void {
         setTimeout(
             () => {
                 message = ''
@@ -63,5 +63,5 @@
     disabled={isBusy}
     {...$$restProps}
 >
-    {overrideTitle || localize('actions.export')}
+    {title || localize('actions.export')}
 </Button>