Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NEW_NOTEBOOK.yml #158

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Update NEW_NOTEBOOK.yml #158

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a01157
Update NEW_NOTEBOOK.yml
MathewBiddle Sep 6, 2023
e087531
Update NEW_NOTEBOOK.yml
MathewBiddle Sep 6, 2023
6e300d8
Update NEW_NOTEBOOK.yml
MathewBiddle Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/ISSUE_TEMPLATE/NEW_NOTEBOOK.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ assignees:
body:
- type: markdown
attributes:
value: |
If you want to suggest a notebook for the [IOOS CodeLab](https://ioos.github.io/ioos_code_lab/content/intro.html#) please answer these questions:
value: If you want to suggest a notebook for the [IOOS CodeLab](https://ioos.github.io/ioos_code_lab/content/intro.html) please answer these questions
- type: input
id: language
attributes:
Expand All @@ -27,10 +26,10 @@ body:
attributes:
label: Module/Software/IOOS data service?
description: Can you provide a minimum example of the expected code and results in a notebook?
placeholder: ""
placeholder: Yes, see this gist.
- type: input
id: description
attributes:
label: Provide a description.
description: Please provide a detailed description of the suggested example below.
placeholder: ""
placeholder: The notebook should detail how to bring source data in, and create an interactive graphical timeseries of the data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add in the placeholder: Example: phrase goes here to avoid users thinking that it is limited to the scope of the phrase. For example, reading it here gives the impression that it must be an interactive graphical representation of the data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. we could remove placeholder...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I just want to make sure folks understand that they are a text example, not a guide.

Loading