-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NEW_NOTEBOOK.yml #158
Conversation
fixing issue template
fixing issue
fixing again
Once merged, https://github.com/ioos/ioos_code_lab/blob/main/CONTRIBUTING.md should be updated. |
- type: input | ||
id: description | ||
attributes: | ||
label: Provide a description. | ||
description: Please provide a detailed description of the suggested example below. | ||
placeholder: "" | ||
placeholder: The notebook should detail how to bring source data in, and create an interactive graphical timeseries of the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add in the placeholder: Example: phrase goes here
to avoid users thinking that it is limited to the scope of the phrase. For example, reading it here gives the impression that it must be an interactive graphical representation of the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. we could remove placeholder
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! I just want to make sure folks understand that they are a text example, not a guide.
Argh. I forgot about this PR and merged #163. I'll revert that one so we can keep work in this one first. |
fixing issue template