Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo #2891

Merged
merged 2 commits into from
Oct 31, 2024
Merged

chore: fix typo #2891

merged 2 commits into from
Oct 31, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Oct 31, 2024 •
edited
Loading

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

f159176 introduced lowercase records in the sidebar

Image

This PR adds menu_label with the correct case. After:

image

The order has been swapped, but I think it is preferable in this order

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

carlinmack referenced this pull request Oct 31, 2024
@Samk13 @utnapischtim
chore: fix typo
f159176 
* change record to lowercase as I double-checked with other references and looks like it is the right way to be lowercase see:
[moderation](https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/administration/user_moderation/user_moderation.py#L25)
[users](https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/administration/users/users.py#L54)
[domains](https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/administration/domains/domains.py#L40)
I also checked in other packages see:
[banners](https://github.com/inveniosoftware/invenio-banners/blob/master/invenio_banners/administration/banners.py#L23)

* Remove what seems to be a typo in the template
* Convert indentations from tabs to spaces
* Fix error  'branded' PropType is defined but prop is never used
utnapischtim
utnapischtim approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@utnapischtim utnapischtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: it would be nice to have a more informative commit message. something like that the menu_label falls back to name

@Samk13
Copy link
Member

Samk13 commented Oct 31, 2024

LGTM!
Thanks for the quick fix!

@zzacharo zzacharo merged commit f2f1ceb into inveniosoftware:master Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samk13 Samk13 Samk13 approved these changes

@utnapischtim utnapischtim utnapischtim approved these changes

@zzacharo zzacharo zzacharo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint Q4/2024 🎄
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlinmack @Samk13 @utnapischtim @zzacharo