-
Notifications
You must be signed in to change notification settings - Fork 151
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* change record to lowercase as I double-checked with other references and looks like it is the right way to be lowercase see: [moderation](https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/administration/user_moderation/user_moderation.py#L25) [users](https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/administration/users/users.py#L54) [domains](https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/administration/domains/domains.py#L40) I also checked in other packages see: [banners](https://github.com/inveniosoftware/invenio-banners/blob/master/invenio_banners/administration/banners.py#L23) * Remove what seems to be a typo in the template * Convert indentations from tabs to spaces * Fix error 'branded' PropType is defined but prop is never used
- Loading branch information
1 parent
3a1b7f2
commit f159176
Showing
4 changed files
with
12 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it should be lowercase π
f159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 103 in invenio_app_rdm/administration/records/records.py has
name = "Drafts"
f159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that mean that the
name
class property should be marked astranslatable
?f159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats strange because the moderation or domain are lowercase too and they are not lowercase in the screenshot
f159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could it be that the error is, that the Records view class has not
menu_label
and therefore falls back toname
? menu_labelf159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/inveniosoftware/invenio-administration/blob/main/invenio_administration/views/base.py#L63-L64 here is the "problem" . so yes, the correct solution would be to add the
menu_label
property toRecordAdminListView
but also toDraftAdminListView
, so that the name could be always lowercasef159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead
menu_label
should be used, I'm making a PRf159176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR: #2891 apologies for sending you down the rabbit hole too :)