is_url: allow urls with parameters #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
reviewed
Nov 2, 2023
tests/test_idutils.py
Outdated
| def test_url(): | ||
| """Test URL validation.""" | ||
| assert idutils.is_url( | ||
| "https://archive.softwareheritage.org/swh:1:dir:44ac666e75004dd2a27ca0e09e73aecc0e8b426f;origin=https://github.com/amykwebster/MIPseq_2021;visit=swh:1:snp:46bcbe75339295c3d68fcf1257022aae8e6bee40;anchor=swh:1:rev:27839dcc9ef1587086be195349310fb70fbfcaf1" |
There was a problem hiding this comment.
Can you also add an example above in the big list of sample identifiers variable? I have a feeling that this should eventually also be identified as a swh identifier.
We can do this later of course by including the http(s)://archive.softwareheritage.org part in the regex.
There was a problem hiding this comment.
swh was actually already in the identifiers list, but with a url that would have failed the validation check. I expanded the test so all the urls in the identifiers variable are now checked.
|
It is useful to link to software directly with a SWHID. #OR2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Software heritage uses urls with parameters, like https://archive.softwareheritage.org/swh:1:dir:44ac666e75004dd2a27ca0e09e73aecc0e8b426f;origin=https://github.com/amykwebster/MIPseq_2021;visit=swh:1:snp:46bcbe75339295c3d68fcf1257022aae8e6bee40;anchor=swh:1:rev:27839dcc9ef1587086be195349310fb70fbfcaf1 . However the idutils is_url function will reject these as not being a valid url.
This PR makes the is_url function more permissive. Software heritage ids and related urls are already in idutils, so it's a bit odd for idutlils to say that they aren't urls.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: