is_url: allow urls with parameters

inveniosoftware · Dec 11, 2023 · 5922118 · 5922118
1 parent 99a3920
commit 5922118
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/idutils/__init__.py b/idutils/__init__.py
@@ -16,12 +16,10 @@
 
 """Small library for persistent identifiers used in scholarly communication."""
 
-from __future__ import absolute_import, print_function
-
 import re
+from urllib.parse import urlparse
 
 import isbnlib
-from six.moves.urllib.parse import urlparse
 
 ENSEMBL_PREFIXES = (
     "ENSPMA",  # Petromyzon marinus (Lamprey)
@@ -548,7 +546,7 @@ def is_purl(val):
 def is_url(val):
     """Test if argument is a URL."""
     res = urlparse(val)
-    return bool(res.scheme and res.netloc and res.params == "")
+    return bool(res.scheme and res.netloc)
 
 
 def is_lsid(val):

diff --git a/tests/test_idutils.py b/tests/test_idutils.py
@@ -866,3 +866,10 @@ def test_ascl():
     assert idutils.is_ascl("ascl:1908.011")
     assert idutils.is_ascl("ascl:1908.0113")
     assert not idutils.is_ascl("1990.0803")
+
+
+def test_url():
+    """Test URL validation."""
+    for i, expected_schemes, normalized_value, url_value in identifiers:
+        if url_value:
+            assert idutils.is_url(url_value)