Various fixes and improvements, including XML support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous MIME type breaks the FHIR .NET API
to avoid URLs like Patient?identifier=urn:oid:0.1.2.3.4.5.6.7|urn:uuid:6002c2ab-9571-4db7-9a79-87163475b071
Chained searches with modifiers (e.g., `foo:Bar.baz`) were not properly parsed and resulted in errors. Now they are properly parsed (e.g., param is `foo`, modifier is `Bar`, and chained query is `baz`). Addresses intervention-engine#93. (cherry picked from commit 3f6fef6)
Uses the FHIR.js library developed by the Lantana Consulting Group (https://github.com/lantanagroup/FHIR.js) as well as the gaja Go-based JavaScript engine
(updated bundled FHIR.js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML support (largely thanks to https://github.com/lantanagroup/FHIR.js and https://github.com/dop251/goja) makes it possible to test using Crucible which should help improve the spec compliance of what is quite a good server (especially from a start-up time & performance point of view).
I've also added a workaround for the lack of transactions into my fork of fhir-server (eug48/fhir-server@bb06f) but with the upcoming support for transactions in MongoDB 4.0 it should be relatively easy to implement them properly.
If this is merged the previous PR (#134) can be closed.