[Writable] only allow writable definitions to be saved #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dpfaffenbauer
commented
Sep 27, 2023
dpfaffenbauer
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
dkarlovi
reviewed
Nov 15, 2023
| @@ -24,7 +24,6 @@ class PimcoreSettingsListener | |||
| { | |||
| public function indexSettings(IndexActionSettingsEvent $settingsEvent): void | |||
| { | |||
| $settingsEvent->addSetting('data-definitions-import-definition-writeable', (new ImportDefinition())->isWriteable()); | |||
| $settingsEvent->addSetting('data-definitions-export-definition-writeable', (new ExportDefinition())->isWriteable()); | |||
|
|
|||
There was a problem hiding this comment.
Ah, just found the issue with this: it is used for the Add button, it gets disabled without this.
There was a problem hiding this comment.
The "Add" button (new import/export profile) will be disabled when not in debug because it relies on this to be present.
There was a problem hiding this comment.
is that a problem?
There was a problem hiding this comment.
Yes because you can't add new profiles even though they're writable? You can edit existing ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.