Merge pull request #394 from dpfaffenbauer/issue/writable

[Writable] only allow writable definitions to be saved
instride-ch · Oct 2, 2023 · a6a33ce · a6a33ce
2 parents 443af0b + 79370b5
commit a6a33ce
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/src/DataDefinitionsBundle/EventListener/PimcoreSettingsListener.php b/src/DataDefinitionsBundle/EventListener/PimcoreSettingsListener.php
@@ -24,7 +24,6 @@ class PimcoreSettingsListener
 {
     public function indexSettings(IndexActionSettingsEvent $settingsEvent): void
     {
-        $settingsEvent->addSetting('data-definitions-import-definition-writeable', (new ImportDefinition())->isWriteable());
-        $settingsEvent->addSetting('data-definitions-export-definition-writeable', (new ExportDefinition())->isWriteable());
+
     }
 }
diff --git a/src/DataDefinitionsBundle/Resources/config/serializer/Model.ExportDefinition.yml b/src/DataDefinitionsBundle/Resources/config/serializer/Model.ExportDefinition.yml
@@ -14,3 +14,8 @@ Wvision\Bundle\DataDefinitionsBundle\Model\ExportDefinition:
       expose: true
       type: boolean
       groups: [ Detailed ]
+  virtual_properties:
+    isWriteable:
+      exp: object.isWriteable()
+      type: boolean
+      serialized_name: isWriteable
diff --git a/src/DataDefinitionsBundle/Resources/config/serializer/Model.ImportDefinition.yml b/src/DataDefinitionsBundle/Resources/config/serializer/Model.ImportDefinition.yml
@@ -50,3 +50,8 @@ Wvision\Bundle\DataDefinitionsBundle\Model\ImportDefinition:
       expose: true
       type: boolean
       groups: [ Detailed ]
+  virtual_properties:
+    isWriteable:
+      exp: object.isWriteable()
+      type: boolean
+      serialized_name: isWriteable
diff --git a/src/DataDefinitionsBundle/Resources/public/pimcore/js/export/item.js b/src/DataDefinitionsBundle/Resources/public/pimcore/js/export/item.js
@@ -25,7 +25,7 @@ pimcore.plugin.datadefinitions.export.item = Class.create(pimcore.plugin.datadef
     providers: [],
 
     saveDisabled: function () {
-        return !pimcore.settings['data-definitions-export-definition-writeable'];
+        return !this.data.isWriteable;
     },
 
     getSettings: function () {

diff --git a/src/DataDefinitionsBundle/Resources/public/pimcore/js/import/item.js b/src/DataDefinitionsBundle/Resources/public/pimcore/js/import/item.js
@@ -26,7 +26,7 @@ pimcore.plugin.datadefinitions.import.item = Class.create(pimcore.plugin.datadef
     providers: [],
 
     saveDisabled: function () {
-        return !pimcore.settings['data-definitions-import-definition-writeable'];
+        return !this.data.isWriteable;
     },
 
     getSettings: function () {